Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing E-scaling test #1307

Closed
wants to merge 1 commit into from
Closed

Fix failing E-scaling test #1307

wants to merge 1 commit into from

Conversation

moralejo
Copy link
Collaborator

@moralejo moralejo commented Oct 9, 2024

This test failed with 3.11 (may be an occasional fail), attempt to fix it.

@morcuended
Copy link
Member

@moralejo see #1300

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.51%. Comparing base (ddcf4f9) to head (d7193a1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lstchain/tools/tests/test_tools.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
- Coverage   73.51%   73.51%   -0.01%     
==========================================
  Files         134      134              
  Lines       14218    14217       -1     
==========================================
- Hits        10453    10451       -2     
- Misses       3765     3766       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moralejo
Copy link
Collaborator Author

moralejo commented Oct 9, 2024

@moralejo see #1300

Damn, actually I vaguely remembered there was something pending related to this scaling...

@moralejo moralejo closed this Oct 9, 2024
@moralejo
Copy link
Collaborator Author

moralejo commented Oct 9, 2024

Merged #1300 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants